]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
tree-optimization/117333 - ICE with NULL access size DR
authorRichard Biener <rguenther@suse.de>
Tue, 29 Oct 2024 08:42:12 +0000 (09:42 +0100)
committerRichard Biener <rguenth@gcc.gnu.org>
Fri, 29 Nov 2024 12:48:33 +0000 (13:48 +0100)
dr_may_alias_p ICEs when TYPE_SIZE of DR->ref is NULL but this is
valid IL when the access size of an aggregate copy can be infered
from the RHS.

PR tree-optimization/117333
* tree-data-ref.cc (dr_may_alias_p): Guard against NULL
access size.

* gcc.dg/torture/pr117333.c: New testcase.

(cherry picked from commit 0e99b22aa666f107c4035d32bfb5ab11534a9d2f)

gcc/testsuite/gcc.dg/torture/pr117333.c [new file with mode: 0644]
gcc/tree-data-ref.cc

diff --git a/gcc/testsuite/gcc.dg/torture/pr117333.c b/gcc/testsuite/gcc.dg/torture/pr117333.c
new file mode 100644 (file)
index 0000000..38c1b54
--- /dev/null
@@ -0,0 +1,29 @@
+/* { dg-do compile } */
+
+struct s
+{
+  unsigned long ul;
+  int i;
+  char ac[];
+};
+
+const struct s gs = { 3, -4, "abcdef" };
+
+void copy_s(struct s*d, const struct s*s)
+{
+  *d = *s;
+}
+
+unsigned test(struct s*ps, _Bool direct)
+{
+  if(direct)
+    *ps = gs;
+  else
+    copy_s(ps, &gs);
+  return sizeof(*ps);
+}
+
+unsigned size(void)
+{
+  return sizeof(gs);
+}
index c9982e2b43d7b8679804703f1e7a33ccd2cde647..501a4593727e988f4ea0cd4639e7c16c392b253b 100644 (file)
@@ -3003,6 +3003,8 @@ dr_may_alias_p (const struct data_reference *a, const struct data_reference *b,
          && DR_BASE_ADDRESS (b)
          && operand_equal_p (DR_BASE_ADDRESS (a), DR_BASE_ADDRESS (b))
          && operand_equal_p (DR_OFFSET (a), DR_OFFSET (b))
+         && tree_size_a
+         && tree_size_b
          && poly_int_tree_p (tree_size_a)
          && poly_int_tree_p (tree_size_b)
          && !ranges_maybe_overlap_p (wi::to_poly_widest (DR_INIT (a)),