[CritFix] Fix memory leak in spf caching logic

MFH: rspamd-1.6

diff --git a/src/plugins/spf.c b/src/plugins/spf.c
index 41e952eb26bdf421faf610e5d8e9532c0f1143af..09bd0fca142938513751bed987b5a556b6774e06 100644 (file)
--- a/src/plugins/spf.c
+++ b/src/plugins/spf.c
@@ -526,15 +526,15 @@ spf_plugin_callback (struct spf_resolved *record, struct rspamd_task *task,
 
                if ((l = rspamd_lru_hash_lookup (spf_module_ctx->spf_hash,
                                        record->domain, task->tv.tv_sec)) == NULL) {
-
-                       l = spf_record_ref (record);
+                       l = record;
 
                        if (record->ttl > 0 &&
                                        !record->temp_failed &&
                                        !record->perm_failed &&
                                        !record->na) {
+
                                rspamd_lru_hash_insert (spf_module_ctx->spf_hash,
-                                               record->domain, l,
+                                               record->domain, spf_record_ref (l),
                                                task->tv.tv_sec, record->ttl);
                        }