]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
x86/crash: Use set_memory_p() instead of __set_memory_prot()
authorCoiby Xu <coxu@redhat.com>
Tue, 6 Jan 2026 09:50:58 +0000 (17:50 +0800)
committerBorislav Petkov (AMD) <bp@alien8.de>
Tue, 13 Jan 2026 14:28:59 +0000 (15:28 +0100)
set_memory_p() is available to use outside of its compilation unit since:

  030ad7af9437 ("x86/mm: Regularize set_memory_p() parameters and make non-static").

There is no use for __set_memory_prot() anymore so drop it too.

  [ bp: Massage commit message. ]

Signed-off-by: Coiby Xu <coxu@redhat.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://patch.msgid.link/20260106095100.656292-1-coxu@redhat.com
arch/x86/include/asm/set_memory.h
arch/x86/kernel/machine_kexec_64.c
arch/x86/mm/pat/set_memory.c

index 61f56cdaccb5af18e36790677b635b4ab6f5e24d..4362c26aa992dba7538ceae40fab713d789e2c8e 100644 (file)
@@ -38,7 +38,6 @@ int set_memory_rox(unsigned long addr, int numpages);
  * The caller is required to take care of these.
  */
 
-int __set_memory_prot(unsigned long addr, int numpages, pgprot_t prot);
 int _set_memory_uc(unsigned long addr, int numpages);
 int _set_memory_wc(unsigned long addr, int numpages);
 int _set_memory_wt(unsigned long addr, int numpages);
index 201137b98fb8e8c5f1dd33964747f4c49f012dc9..0590d399d4f1f645c171426f52065f7c96c2a99e 100644 (file)
@@ -673,10 +673,7 @@ static void kexec_mark_dm_crypt_keys(bool protect)
                if (protect)
                        set_memory_np((unsigned long)phys_to_virt(start_paddr), nr_pages);
                else
-                       __set_memory_prot(
-                               (unsigned long)phys_to_virt(start_paddr),
-                               nr_pages,
-                               __pgprot(_PAGE_PRESENT | _PAGE_NX | _PAGE_RW));
+                       set_memory_p((unsigned long)phys_to_virt(start_paddr), nr_pages);
        }
 }
 
index 6c6eb486f7a61ff176e78c41f1825c594fd4970e..40581a720fe82934fc0976f882dca69a9887f295 100644 (file)
@@ -2145,19 +2145,6 @@ static inline int cpa_clear_pages_array(struct page **pages, int numpages,
                CPA_PAGES_ARRAY, pages);
 }
 
-/*
- * __set_memory_prot is an internal helper for callers that have been passed
- * a pgprot_t value from upper layers and a reservation has already been taken.
- * If you want to set the pgprot to a specific page protocol, use the
- * set_memory_xx() functions.
- */
-int __set_memory_prot(unsigned long addr, int numpages, pgprot_t prot)
-{
-       return change_page_attr_set_clr(&addr, numpages, prot,
-                                       __pgprot(~pgprot_val(prot)), 0, 0,
-                                       NULL);
-}
-
 int _set_memory_uc(unsigned long addr, int numpages)
 {
        /*