]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rtw89: ser: leave lps with mutex
authorZong-Zhe Yang <kevin_yang@realtek.com>
Mon, 4 Jul 2022 02:34:51 +0000 (10:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:58:12 +0000 (09:58 +0200)
[ Upstream commit 8676031bae1c91037d06341214f4150b33707c68 ]

Calling rtw89_leave_lps() should hold rtwdev::mutex.
So, fix it.

Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220704023453.19935-5-pkshih@realtek.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/realtek/rtw89/ser.c

index 9e95ed9727108e35bfa589dae7a0a6db23aa00d2..5d88200cbd3e53765e87ddb2de07cec6c8f33259 100644 (file)
@@ -152,7 +152,10 @@ static void ser_state_run(struct rtw89_ser *ser, u8 evt)
        rtw89_debug(rtwdev, RTW89_DBG_SER, "ser: %s receive %s\n",
                    ser_st_name(ser), ser_ev_name(ser, evt));
 
+       mutex_lock(&rtwdev->mutex);
        rtw89_leave_lps(rtwdev);
+       mutex_unlock(&rtwdev->mutex);
+
        ser->st_tbl[ser->state].st_func(ser, evt);
 }