python:lsa_utils: Don't use optional arguments for OpenPolicyFallback()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15680

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit f9a3fc19f1e212c54351c3f94978e66fceeb8835)

diff --git a/python/samba/lsa_utils.py b/python/samba/lsa_utils.py
index 043e65f3341bbddb7560b04db7bb0dccae77e667..571beb46c851dd97a4f1fd3953799018942501bd 100644 (file)
--- a/python/samba/lsa_utils.py
+++ b/python/samba/lsa_utils.py
@@ -35,8 +35,8 @@ def OpenPolicyFallback(
     system_name: str,
     in_version: int,
     in_revision_info: lsa.revision_info1,
-    sec_qos: bool = False,
-    access_mask: int = 0,
+    sec_qos: bool,
+    access_mask: int,
 ):
     attr = lsa.ObjectAttribute()
     if sec_qos:

diff --git a/python/samba/netcmd/domain/trust.py b/python/samba/netcmd/domain/trust.py
index 0784fa5e28220207bc5cf619b3a0600fb3de6cd4..f39d4814a111e4d868f63fded6a8628c1bc69dab 100644 (file)
--- a/python/samba/netcmd/domain/trust.py
+++ b/python/samba/netcmd/domain/trust.py
@@ -222,6 +222,7 @@ class DomainTrustCommand(Command):
             b''.decode('utf-8'),
             in_version,
             in_revision_info1,
+            False,
             policy_access
         )
 

diff --git a/python/samba/tests/dcerpc/lsa_utils.py b/python/samba/tests/dcerpc/lsa_utils.py
index 229f57ec5468d3409cc584fa585ee9e27e6f1a52..fee9a45419bda9ac9f2ce5e11d1b33de2d76b929 100644 (file)
--- a/python/samba/tests/dcerpc/lsa_utils.py
+++ b/python/samba/tests/dcerpc/lsa_utils.py
@@ -79,7 +79,8 @@ class CreateTrustedDomain(TestCase):
             '',
             in_version,
             in_revision_info1,
-            access_mask=security.SEC_FLAG_MAXIMUM_ALLOWED
+            False,
+            security.SEC_FLAG_MAXIMUM_ALLOWED
         )
         self.assertIsNotNone(pol_handle)
 
@@ -168,7 +169,8 @@ class CreateTrustedDomain(TestCase):
             '',
             in_version,
             in_revision_info1,
-            access_mask=security.SEC_FLAG_MAXIMUM_ALLOWED
+            False,
+            security.SEC_FLAG_MAXIMUM_ALLOWED
         )
         self.assertIsNotNone(pol_handle)
 

diff --git a/python/samba/tests/krb5/kdc_base_test.py b/python/samba/tests/krb5/kdc_base_test.py
index 17877aa886378faa27830a806e84f6bec0a304df..1da770e4fe8c88c07d451197c6fa7ee0ee66a49b 100644 (file)
--- a/python/samba/tests/krb5/kdc_base_test.py
+++ b/python/samba/tests/krb5/kdc_base_test.py
@@ -454,7 +454,8 @@ class KDCBaseTest(TestCaseInTempDir, RawKerberosTest):
                 b''.decode('utf-8'),
                 in_version,
                 in_revision_info1,
-                access_mask=policy_access
+                False,
+                policy_access
             )
 
             info = conn.QueryInfoPolicy2(policy, lsa.LSA_POLICY_INFO_DNS)