]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: hotplug: Don't leak 'nodename' in qemuDomainChangeMediaBlockdev
authorPeter Krempa <pkrempa@redhat.com>
Wed, 22 Aug 2018 11:09:50 +0000 (13:09 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 22 Aug 2018 11:55:26 +0000 (13:55 +0200)
qemuDomainDiskGetBackendAlias allocates a copy of the nodename string so
we need to free it at the end.

Found by Coverity.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/qemu/qemu_hotplug.c

index 1a9a9e1a327d20b84c32331cd06126055944c8ee..0b84a503bb3571bd56b14f7e97b2c0146ac65abb 100644 (file)
@@ -700,6 +700,7 @@ qemuDomainChangeMediaBlockdev(virQEMUDriverPtr driver,
  cleanup:
     qemuHotplugDiskSourceDataFree(newbackend);
     qemuHotplugDiskSourceDataFree(oldbackend);
+    VIR_FREE(nodename);
     /* caller handles correct exchange of sources */
     disk->src = oldsrc;
     return ret;