]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
HID: multitouch: fix name of Stylus input devices
authorThadeu Lima de Souza Cascardo <cascardo@igalia.com>
Wed, 8 Oct 2025 12:40:33 +0000 (09:40 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Oct 2025 14:24:37 +0000 (16:24 +0200)
[ Upstream commit aa4daea418ee4215dca5c8636090660c545cb233 ]

HID_DG_PEN devices should have a suffix of "Stylus", as pointed out by
commit c0ee1d571626 ("HID: hid-input: Add suffix also for HID_DG_PEN").
However, on multitouch devices, these suffixes may be overridden. Before
that commit, HID_DG_PEN devices would get the "Stylus" suffix, but after
that, multitouch would override them to have an "UNKNOWN" suffix. Just add
HID_DG_PEN to the list of non-overriden suffixes in multitouch.

Before this fix:

[    0.470981] input: ELAN9008:00 04F3:2E14 UNKNOWN as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-16/i2c-ELAN9008:00/0018:04F3:2E14.0001/input/input8
ELAN9008:00 04F3:2E14 UNKNOWN

After this fix:

[    0.474332] input: ELAN9008:00 04F3:2E14 Stylus as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-16/i2c-ELAN9008:00/0018:04F3:2E14.0001/input/input8

ELAN9008:00 04F3:2E14 Stylus

Fixes: c0ee1d571626 ("HID: hid-input: Add suffix also for HID_DG_PEN")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-multitouch.c

index 7587a7748a82da7b8631c29385307847d8ffa80f..a9ff84f0bd9bbe056783fc6fd37676c902e0e135 100644 (file)
@@ -1711,6 +1711,7 @@ static int mt_input_configured(struct hid_device *hdev, struct hid_input *hi)
        case HID_CP_CONSUMER_CONTROL:
        case HID_GD_WIRELESS_RADIO_CTLS:
        case HID_GD_SYSTEM_MULTIAXIS:
+       case HID_DG_PEN:
                /* already handled by hid core */
                break;
        case HID_DG_TOUCHSCREEN: