]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Remove XXXs about Making CGO disable-able
authorNick Mathewson <nickm@torproject.org>
Tue, 10 Jun 2025 14:32:20 +0000 (10:32 -0400)
committerNick Mathewson <nickm@torproject.org>
Tue, 10 Jun 2025 23:06:47 +0000 (19:06 -0400)
src/core/crypto/onion_crypto.c
src/core/or/circuitbuild.c
src/core/or/extendinfo.c
src/core/or/protover.c

index 7e7181d282afc24e6d5aff5232f5552de63668da..ba6f3c098706acfde492e1ee3c7b51597a66f5e5 100644 (file)
@@ -282,7 +282,6 @@ relay_process_subproto_ext(const trn_extension_t *ext,
 
     if (cur->protocol_id == PRT_RELAY &&
         cur->proto_cap_number == PROTOVER_RELAY_CRYPT_CGO) {
-      // XXXX CGO: Should we test if CGO is enabled at the relay?
       params_out->crypto_alg = RELAY_CRYPTO_ALG_CGO_RELAY;
       params_out->cell_fmt = RELAY_CELL_FORMAT_V1;
     } else {
index 26ff519f6d1927279353c534109840f7736373b2..ebabb806c7231e02eb14573cf9e6210c982c7b1b 100644 (file)
@@ -886,7 +886,6 @@ circuit_pick_create_handshake(uint8_t *cell_type_out,
       congestion_control_enabled())
     *handshake_type_out = ONION_HANDSHAKE_TYPE_NTOR_V3;
   else if (ei->enable_cgo)
-    // XXXX CGO: provide an enable option?
     *handshake_type_out = ONION_HANDSHAKE_TYPE_NTOR_V3;
   else
     *handshake_type_out = ONION_HANDSHAKE_TYPE_NTOR;
index 7ee0d26a125621a4bdcfc3255d95996255cc7923..2fd83697fa599dff427d6b22c73228a3781b5a24 100644 (file)
@@ -63,8 +63,6 @@ extend_info_new(const char *nickname,
 
   if (pv) {
     info->supports_ntor_v3 = pv->supports_ntor_v3;
-
-    // XXXX cgo Decide whether to set this!
     info->enable_cgo = pv->supports_cgo;
   }
 
index f609a5f632f403e7cfd22bccfacdf8d346393d13..205be5d4ef60f96f375b955182162542f3382d55 100644 (file)
@@ -399,7 +399,6 @@ protocol_list_supports_protocol_or_later(const char *list,
 #define PR_LINKAUTH_V  "3"
 #define PR_MICRODESC_V "1-3"
 #define PR_PADDING_V   "2"
-// XXXX CGO: Make 6 conditional?
 #define PR_RELAY_V     "2-6"
 
 /** Return the string containing the supported version for the given protocol