xen_xl: Check for virConfSetValue() retval

There's one case where the return value of virConfSetValue() is
not checked for and it's in xenFormatXLInputDevs() function.
Let's fix that.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c
index 94268fb76d47203e8ab7a468f4877a2e6a9f66ea..e3ddae88270e1bfe705464242a91981133ca87ef 100644 (file)
--- a/src/libxl/xen_xl.c
+++ b/src/libxl/xen_xl.c
@@ -1853,7 +1853,11 @@ xenFormatXLInputDevs(virConf *conf, virDomainDef *def)
                     goto error;
                 virConfFreeValue(usbdevices);
             } else {
-                virConfSetValue(conf, "usbdevice", usbdevices);
+                if (virConfSetValue(conf, "usbdevice", usbdevices) < 0) {
+                    usbdevices = NULL;
+                    goto error;
+                }
+                usbdevices = NULL;
             }
         } else {
             VIR_FREE(usbdevices);