added -Wformat-security flag, as recommended by @pixelb

diff --git a/Makefile b/Makefile
index 0f97e6c5baa83804e37b2d366c8cafe3b9c5fde8..f0492d944f31e555bc54e573a1380e37d7dfcf23 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -23,7 +23,7 @@ EXT =
 endif
 
 .PHONY: default
-default: lib zstd-release
+default: lib-release zstd-release
 
 .PHONY: all
 all: | allmost examples manual
@@ -42,6 +42,10 @@ all32:
 
 .PHONY: lib
 lib:
+       @$(MAKE) -C $(ZSTDDIR) $@
+
+.PHONY: lib-release
+lib-release:
        @$(MAKE) -C $(ZSTDDIR)
 
 .PHONY: zstd

diff --git a/NEWS b/NEWS
index 760724a25b14fcd8809dccfc18734390e055454c..9073a8724e39d3e83a5c53625e1345986dcc637a 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -9,6 +9,7 @@ arch : 32-bits variant able to generate and decode very long matches (>32 MB), b
 API : new : ZSTD_findFrameCompressedSize(), ZSTD_getFrameContentSize(), ZSTD_findDecompressedSize()
 build: new: meson build system in contrib/meson, by Dima Krasner
 build: improved cmake script, by @Majlen
+build: added -Wformat-security flag, as recommended by Padraig Brady
 doc : new : educational decoder, by Sean Purcell
 
 v1.1.3

diff --git a/lib/Makefile b/lib/Makefile
index 05dd2bc9a51fe421ac0eb48585f2454873b5da01..58f99baf531a4c4bbdf22d6f3ce3ccb73f46065a 100644 (file)
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -24,7 +24,7 @@ CPPFLAGS+= -I. -I./common -DXXH_NAMESPACE=ZSTD_
 CFLAGS  ?= -O3
 DEBUGFLAGS = -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow \
            -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement \
-           -Wstrict-prototypes -Wundef -Wpointer-arith
+           -Wstrict-prototypes -Wundef -Wpointer-arith -Wformat-security
 CFLAGS  += $(DEBUGFLAGS) $(MOREFLAGS)
 FLAGS    = $(CPPFLAGS) $(CFLAGS)
 

diff --git a/programs/Makefile b/programs/Makefile
index 407a4f374716c817d6f37008db6f68a837f597bb..5620a25a379995b586e71c6e56f4794f8467109a 100644 (file)
--- a/programs/Makefile
+++ b/programs/Makefile
@@ -30,7 +30,7 @@ CPPFLAGS+= -I$(ZSTDDIR) -I$(ZSTDDIR)/common -I$(ZSTDDIR)/compress \
 CFLAGS  ?= -O3
 DEBUGFLAGS = -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow \
           -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement \
-          -Wstrict-prototypes -Wundef -Wpointer-arith
+          -Wstrict-prototypes -Wundef -Wpointer-arith -Wformat-security
 CFLAGS  += $(DEBUGFLAGS) $(MOREFLAGS)
 FLAGS    = $(CPPFLAGS) $(CFLAGS) $(LDFLAGS)
 

diff --git a/tests/Makefile b/tests/Makefile
index 88c58fce4840396220f3cf33e4feb669badac0d6..8b19aa3d515448e7ba0b8561c9f2450c0dbd66cb 100644 (file)
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -28,8 +28,9 @@ TESTARTEFACT := versionsTest namespaceTest
 
 CPPFLAGS+= -I$(ZSTDDIR) -I$(ZSTDDIR)/common -I$(ZSTDDIR)/compress -I$(ZSTDDIR)/dictBuilder -I$(ZSTDDIR)/deprecated -I$(PRGDIR)
 CFLAGS  ?= -O3
-CFLAGS  += -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 \
-           -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef
+CFLAGS  += -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow \
+           -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement \
+           -Wstrict-prototypes -Wundef -Wformat-security
 CFLAGS  += $(MOREFLAGS)
 FLAGS    = $(CPPFLAGS) $(CFLAGS) $(LDFLAGS)