]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
KVM: arm64: selftests: vgic_irq: Change configuration before enabling interrupt
authorMarc Zyngier <maz@kernel.org>
Thu, 20 Nov 2025 17:25:33 +0000 (17:25 +0000)
committerOliver Upton <oupton@kernel.org>
Mon, 24 Nov 2025 22:29:15 +0000 (14:29 -0800)
The architecture is pretty clear that changing the configuration of
an enable interrupt is not OK. It doesn't really matter here, but
doing the right thing is not more expensive.

Tested-by: Fuad Tabba <tabba@google.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Tested-by: Mark Brown <broonie@kernel.org>
Link: https://msgid.link/20251120172540.2267180-44-maz@kernel.org
Signed-off-by: Oliver Upton <oupton@kernel.org>
tools/testing/selftests/kvm/arm64/vgic_irq.c

index a77562b2976aeab20b90dc29ca660568f2e2e0fa..a8919ef3cea2ea17141b3f47bc7f8379310a6ba9 100644 (file)
@@ -473,12 +473,12 @@ static void guest_code(struct test_args *args)
 
        gic_init(GIC_V3, 1);
 
-       for (i = 0; i < nr_irqs; i++)
-               gic_irq_enable(i);
-
        for (i = MIN_SPI; i < nr_irqs; i++)
                gic_irq_set_config(i, !level_sensitive);
 
+       for (i = 0; i < nr_irqs; i++)
+               gic_irq_enable(i);
+
        gic_set_eoi_split(args->eoi_split);
 
        reset_priorities(args);