media: stm32-dcmi: use devm_kmemdup_array()

Convert to use devm_kmemdup_array() and while at it, make the size robust
against type changes.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
index 9b699ee2b1e0614c22f68da2709b54c85e5024bd..ba77062357eb7564777adb05b3618eeb7a866222 100644 (file)
--- a/drivers/media/platform/st/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
@@ -1682,18 +1682,14 @@ static int dcmi_formats_init(struct stm32_dcmi *dcmi)
                return -ENXIO;
 
        dcmi->num_of_sd_formats = num_fmts;
-       dcmi->sd_formats = devm_kcalloc(dcmi->dev,
-                                       num_fmts, sizeof(struct dcmi_format *),
-                                       GFP_KERNEL);
+       dcmi->sd_formats = devm_kmemdup_array(dcmi->dev, sd_fmts, num_fmts,
+                                             sizeof(*sd_fmts), GFP_KERNEL);
        if (!dcmi->sd_formats) {
                dev_err(dcmi->dev, "Could not allocate memory\n");
                return -ENOMEM;
        }
 
-       memcpy(dcmi->sd_formats, sd_fmts,
-              num_fmts * sizeof(struct dcmi_format *));
        dcmi->sd_format = dcmi->sd_formats[0];
-
        return 0;
 }