fts: struct fts_transaction_context - Assert not indexing rather than do it conditionally

diff --git a/src/plugins/fts/fts-storage.c b/src/plugins/fts/fts-storage.c
index 9bc0a36a4dfc8a7883265421f5dab62cc4e91f8f..b7b1b2b6f2cfd262383b87ddd4a778ef8dbdc0f9 100644 (file)
--- a/src/plugins/fts/fts-storage.c
+++ b/src/plugins/fts/fts-storage.c
@@ -554,12 +554,13 @@ static int fts_mail_precache(struct mail *_mail)
        struct mail_private *mail = (struct mail_private *)_mail;
        struct fts_mail *fmail = FTS_MAIL_CONTEXT(mail);
        struct fts_transaction_context *ft = FTS_CONTEXT_REQUIRE(_mail->transaction);
-       int ret = 0;
+       int ret;
 
        i_assert(!fmail->virtual_mail);
        fmail->module_ctx.super.precache(_mail);
-       if (!ft->indexing) T_BEGIN {
-               /* avoid recursing here from fts_mail_precache_range() */
+
+       i_assert(!ft->indexing);
+       T_BEGIN {
                struct event_reason *reason =
                        event_reason_begin("fts:index");
                ft->indexing = TRUE;