]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: freescale: Discard pm_runtime_put() return value
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 22 Dec 2025 20:18:46 +0000 (21:18 +0100)
committerVinod Koul <vkoul@kernel.org>
Tue, 23 Dec 2025 17:41:03 +0000 (23:11 +0530)
Printing error messages on pm_runtime_put() returning negative values
is not particularly useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.

Accordingly, update mixel_lvds_phy_reset() to simply discard the return
value of pm_runtime_put().

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2012926.taCxCBeP46@rafael.j.wysocki
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c

index 7aef2f59e8eb4adc055c6e6f325351763435bbf7..ece35744352170ca4543c1c81f3787f16fe426a6 100644 (file)
@@ -286,11 +286,9 @@ static int mixel_lvds_phy_reset(struct device *dev)
 
        regmap_write(priv->regmap, PHY_CTRL, CTRL_RESET_VAL);
 
-       ret = pm_runtime_put(dev);
-       if (ret < 0)
-               dev_err(dev, "failed to put PM runtime: %d\n", ret);
+       pm_runtime_put(dev);
 
-       return ret;
+       return 0;
 }
 
 static struct phy *mixel_lvds_phy_xlate(struct device *dev,