]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
vfio/pci: Disable qword access to the VGA region
authorKevin Tian <kevin.tian@intel.com>
Thu, 18 Dec 2025 08:16:50 +0000 (08:16 +0000)
committerAlex Williamson <alex@shazbot.org>
Tue, 23 Dec 2025 21:07:08 +0000 (14:07 -0700)
Seems no reason to allow qword access to the old VGA resource. Better
restrict it to dword access as before.

Suggested-by: Alex Williamson <alex@shazbot.org>
Signed-off-by: Kevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/20251218081650.555015-3-kevin.tian@intel.com
Signed-off-by: Alex Williamson <alex@shazbot.org>
drivers/vfio/pci/vfio_pci_rdwr.c

index 25380b7dfe18a7358998ab44b3adb192ad6b44ee..b38627b35c35d6266d6be45906bbb27fe0190a59 100644 (file)
@@ -363,7 +363,7 @@ ssize_t vfio_pci_vga_rw(struct vfio_pci_core_device *vdev, char __user *buf,
         * to the memory enable bit in the command register.
         */
        done = vfio_pci_core_do_io_rw(vdev, false, iomem, buf, off, count,
-                                     0, 0, iswrite, VFIO_PCI_IO_WIDTH_8);
+                                     0, 0, iswrite, VFIO_PCI_IO_WIDTH_4);
 
        vga_put(vdev->pdev, rsrc);