Require a semicolon for VIR_LOG_INIT calls

Missing semicolon at the end of macros can confuse some analyzers
(like cppcheck <filename>), and we have a mix of semicolon and
non-semicolon usage through the code. Let's standardize on using
a semicolon for VIR_LOG_INIT calls.

Drop the semicolon from the final statement of the macro, so
the compiler will require callers to add a semicolon.

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Cole Robinson <crobinso@redhat.com>

diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c
index 25f51b1acb610829fca4bc716c279067de2bb218..be39b35da2596507334bf8309e0ac16e187a9859 100644 (file)
--- a/src/conf/capabilities.c
+++ b/src/conf/capabilities.c
@@ -45,7 +45,7 @@
 
 #define SYSFS_SYSTEM_PATH "/sys/devices/system"
 
-VIR_LOG_INIT("conf.capabilities")
+VIR_LOG_INIT("conf.capabilities");
 
 VIR_ENUM_DECL(virCapsHostPMTarget);
 VIR_ENUM_IMPL(virCapsHostPMTarget, VIR_NODE_SUSPEND_TARGET_LAST,

diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c
index 5775563508a472a1d6eaf0ca41d65a1c80c547fc..a21caefabae00e5d125fc8812ee3277bd968c852 100644 (file)
--- a/src/qemu/qemu_extdevice.c
+++ b/src/qemu/qemu_extdevice.c
@@ -33,7 +33,7 @@
 
 #define VIR_FROM_THIS VIR_FROM_QEMU
 
-VIR_LOG_INIT("qemu.qemu_extdevice")
+VIR_LOG_INIT("qemu.qemu_extdevice");
 
 int
 qemuExtDeviceLogCommand(qemuDomainLogContextPtr logCtxt,

diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
index 15b6ab8870d96ccca8a68e755d09be4ac77f15a2..835a9caf46343632ec59169cbc234682509d1d3c 100644 (file)
--- a/src/qemu/qemu_tpm.c
+++ b/src/qemu/qemu_tpm.c
@@ -44,7 +44,7 @@
 
 #define VIR_FROM_THIS VIR_FROM_NONE
 
-VIR_LOG_INIT("qemu.tpm")
+VIR_LOG_INIT("qemu.tpm");
 
 /*
  * executables for the swtpm; to be found on the host

diff --git a/src/util/virfilecache.c b/src/util/virfilecache.c
index 15c0d99fd9b530548920a80d544334c957742594..eb7dbd97ccec7ad026ed519946c238bb9641fb4c 100644 (file)
--- a/src/util/virfilecache.c
+++ b/src/util/virfilecache.c
@@ -41,7 +41,7 @@
 
 #define VIR_FROM_THIS VIR_FROM_NONE
 
-VIR_LOG_INIT("util.filecache")
+VIR_LOG_INIT("util.filecache");
 
 
 struct _virFileCache {

diff --git a/src/util/virlog.h b/src/util/virlog.h
index 8edd39037859d316e15d482bc1b42302393d82b5..775a726b063784ff9c7da131f7cb9a59cb172184 100644 (file)
--- a/src/util/virlog.h
+++ b/src/util/virlog.h
@@ -79,7 +79,7 @@ struct _virLogSource {
         .priority = VIR_LOG_ERROR, \
         .serial = 0, \
         .flags = 0, \
-    };
+    }
 
 /*
  * If configured with --enable-debug=yes then library calls

diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index 23563fe925c4ec5e2a203f0be2f8d487a5425d12..9e5a14158f071decd6066822087828d1ea2e9c3f 100644 (file)
--- a/src/util/virresctrl.c
+++ b/src/util/virresctrl.c
@@ -33,7 +33,7 @@
 
 #define VIR_FROM_THIS VIR_FROM_RESCTRL
 
-VIR_LOG_INIT("util.virresctrl")
+VIR_LOG_INIT("util.virresctrl");
 
 
 /* Resctrl is short for Resource Control.  It might be implemented for various