]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: sim: Use correct order for the parameters of devm_kcalloc()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 20 May 2022 19:21:56 +0000 (21:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:26:10 +0000 (10:26 +0200)
[ Upstream commit c680c6a814a2269427fad9ac417ab16756bceae9 ]

We should have 'n', then 'size', not the opposite.
This is harmless because the 2 values are just multiplied, but having
the correct order silence a (unpublished yet) smatch warning.

Fixes: cb8c474e79be ("gpio: sim: new testing module")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-sim.c

index 41c31b10ae8488c5a897bdced43f99afa60bf985..98109839102fba84dd8a809cebc0d36172c1a4fb 100644 (file)
@@ -314,8 +314,8 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
 
        for (i = 0; i < num_lines; i++) {
                attr_group = devm_kzalloc(dev, sizeof(*attr_group), GFP_KERNEL);
-               attrs = devm_kcalloc(dev, sizeof(*attrs),
-                                    GPIO_SIM_NUM_ATTRS, GFP_KERNEL);
+               attrs = devm_kcalloc(dev, GPIO_SIM_NUM_ATTRS, sizeof(*attrs),
+                                    GFP_KERNEL);
                val_attr = devm_kzalloc(dev, sizeof(*val_attr), GFP_KERNEL);
                pull_attr = devm_kzalloc(dev, sizeof(*pull_attr), GFP_KERNEL);
                if (!attr_group || !attrs || !val_attr || !pull_attr)