]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/dram: Sort SKL+ DIMM register bits
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 29 Oct 2025 20:42:14 +0000 (22:42 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 19 Nov 2025 16:55:04 +0000 (18:55 +0200)
Use the customary big endian order when defining the
SKL/ICL DIMM registers.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20251029204215.12292-3-ville.syrjala@linux.intel.com
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/i915/intel_mchbar_regs.h

index 378dc7c69f7d4c5920fa485df2dfc5762aa4c892..a46a45b9d2e1a7bdde12d7d8cf5fc8ba6fb0f5ff 100644 (file)
 #define SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN   _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x500C)
 #define SKL_MAD_DIMM_CH1_0_0_0_MCHBAR_MCMAIN   _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5010)
 #define   SKL_DRAM_S_SHIFT                     16
-#define   SKL_DRAM_SIZE_MASK                   REG_GENMASK(5, 0)
+#define   SKL_DRAM_RANK_MASK                   REG_GENMASK(10, 10)
+#define   SKL_DRAM_RANK_1                      REG_FIELD_PREP(SKL_DRAM_RANK_MASK, 0)
+#define   SKL_DRAM_RANK_2                      REG_FIELD_PREP(SKL_DRAM_RANK_MASK, 1)
 #define   SKL_DRAM_WIDTH_MASK                  REG_GENMASK(9, 8)
 #define   SKL_DRAM_WIDTH_X8                    REG_FIELD_PREP(SKL_DRAM_WIDTH_MASK, 0)
 #define   SKL_DRAM_WIDTH_X16                   REG_FIELD_PREP(SKL_DRAM_WIDTH_MASK, 1)
 #define   SKL_DRAM_WIDTH_X32                   REG_FIELD_PREP(SKL_DRAM_WIDTH_MASK, 2)
-#define   SKL_DRAM_RANK_MASK                   REG_GENMASK(10, 10)
-#define   SKL_DRAM_RANK_1                      REG_FIELD_PREP(SKL_DRAM_RANK_MASK, 0)
-#define   SKL_DRAM_RANK_2                      REG_FIELD_PREP(SKL_DRAM_RANK_MASK, 1)
-#define   ICL_DRAM_SIZE_MASK                   REG_GENMASK(6, 0)
-#define   ICL_DRAM_WIDTH_MASK                  REG_GENMASK(8, 7)
-#define   ICL_DRAM_WIDTH_X8                    REG_FIELD_PREP(ICL_DRAM_WIDTH_MASK, 0)
-#define   ICL_DRAM_WIDTH_X16                   REG_FIELD_PREP(ICL_DRAM_WIDTH_MASK, 1)
-#define   ICL_DRAM_WIDTH_X32                   REG_FIELD_PREP(ICL_DRAM_WIDTH_MASK, 2)
+#define   SKL_DRAM_SIZE_MASK                   REG_GENMASK(5, 0)
 #define   ICL_DRAM_RANK_MASK                   REG_GENMASK(10, 9)
 #define   ICL_DRAM_RANK_1                      REG_FIELD_PREP(ICL_DRAM_RANK_MASK, 0)
 #define   ICL_DRAM_RANK_2                      REG_FIELD_PREP(ICL_DRAM_RANK_MASK, 1)
 #define   ICL_DRAM_RANK_3                      REG_FIELD_PREP(ICL_DRAM_RANK_MASK, 2)
 #define   ICL_DRAM_RANK_4                      REG_FIELD_PREP(ICL_DRAM_RANK_MASK, 3)
+#define   ICL_DRAM_WIDTH_MASK                  REG_GENMASK(8, 7)
+#define   ICL_DRAM_WIDTH_X8                    REG_FIELD_PREP(ICL_DRAM_WIDTH_MASK, 0)
+#define   ICL_DRAM_WIDTH_X16                   REG_FIELD_PREP(ICL_DRAM_WIDTH_MASK, 1)
+#define   ICL_DRAM_WIDTH_X32                   REG_FIELD_PREP(ICL_DRAM_WIDTH_MASK, 2)
+#define   ICL_DRAM_SIZE_MASK                   REG_GENMASK(6, 0)
 
 #define SA_PERF_STATUS_0_0_0_MCHBAR_PC         _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5918)
 #define  DG1_QCLK_RATIO_MASK                   REG_GENMASK(9, 2)