]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: block: forbid creation of storage sources with <slice>
authorPeter Krempa <pkrempa@redhat.com>
Wed, 12 Feb 2020 16:26:47 +0000 (17:26 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 14 Feb 2020 15:32:21 +0000 (16:32 +0100)
Specifically creating such images via libvirt during blockjobs would
be much more hassle than it's worth. Just forbid them for now.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_block.c

index b408d4c81f07d8eaa346ccd9965d42734667d871..1147f4d3af3569d1826dd4dad2550c7ed642a635 100644 (file)
@@ -2529,6 +2529,12 @@ qemuBlockStorageSourceCreate(virDomainObjPtr vm,
     int ret = -1;
     int rc;
 
+    if (src->sliceStorage) {
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
+                       _("creation of images with slice type='storage' is not supported"));
+        return -1;
+    }
+
     if (qemuDomainObjEnterMonitorAsync(priv->driver, vm, asyncJob) < 0)
         goto cleanup;