]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4-drs: actually call the new drsuapi_add_SPNs() code
authorAndrew Tridgell <tridge@samba.org>
Fri, 11 Sep 2009 07:13:28 +0000 (17:13 +1000)
committerAndrew Tridgell <tridge@samba.org>
Fri, 11 Sep 2009 07:13:28 +0000 (17:13 +1000)
An early return here didn't do any good :-)

source4/rpc_server/drsuapi/addentry.c

index ab190e1a7951ebad21f67ecd41e381daadfbcedc..4ccf14d93a4851973f8e78372c0fbc9aaae8fb9b 100644 (file)
@@ -105,7 +105,7 @@ static WERROR drsuapi_add_SPNs(struct drsuapi_bind_state *b_state,
                el->values[0].length = strlen((char *)el->values[0].data);
                el->values[1].data = (uint8_t *)talloc_asprintf(el->values, "ldap/%s/%s", 
                                                                ntds_guid_str, dom_string);
-               el->values[1].length = strlen((char *)el->values[0].data);
+               el->values[1].length = strlen((char *)el->values[1].data);
 
                ret = ldb_modify(b_state->sam_ctx, msg);
                if (ret != LDB_SUCCESS) {
@@ -173,7 +173,7 @@ WERROR dcesrv_drsuapi_DsAddEntry(struct dcesrv_call_state *dce_call, TALLOC_CTX
                r->out.ctr->ctr3.count = num;
                r->out.ctr->ctr3.objects = ids;
 
-               return WERR_OK;
+               break;
        default:
                return WERR_FOOBAR;
        }