]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
libstdc++: Fix tr1/8_c_compatibility/cstdio/functions.cc regression with recent glibc
authorJakub Jelinek <jakub@redhat.com>
Fri, 13 Oct 2023 07:09:32 +0000 (09:09 +0200)
committerJakub Jelinek <jakub@redhat.com>
Sun, 17 Dec 2023 13:54:42 +0000 (14:54 +0100)
The following testcase started FAILing recently after the
https://sourceware.org/git/?p=glibc.git;a=commit;h=64b1a44183a3094672ed304532bedb9acc707554
glibc change which marked vfscanf with nonnull (1) attribute.
While vfwscanf hasn't been marked similarly (strangely), the patch changes
that too.  By using va_arg one hides the value of it from the compiler
(volatile keyword would do too, or making the FILE* stream a function
argument, but then it might need to be guarded by #if or something).

2023-10-13  Jakub Jelinek  <jakub@redhat.com>

* testsuite/tr1/8_c_compatibility/cstdio/functions.cc (test01):
Initialize stream to va_arg(ap, FILE*) rather than 0.
* testsuite/tr1/8_c_compatibility/cwchar/functions.cc (test01):
Likewise.

(cherry picked from commit badb798f5e96a995bb9fa8c4ea48071aa4f2b4b3)

libstdc++-v3/testsuite/tr1/8_c_compatibility/cstdio/functions.cc
libstdc++-v3/testsuite/tr1/8_c_compatibility/cwchar/functions.cc

index 2d9371bb590d2c2f75a20e5e86c5ae7eb7f7aa20..a62e1fe3dc2f4693eb6e2d824dd3d1c567803602 100644 (file)
@@ -35,7 +35,7 @@ void test01(int dummy, ...)
   char* s = 0;
   const char* cs = 0;
   const char* format = "%i";
-  FILE* stream = 0;
+  FILE* stream = va_arg(ap, FILE*);
   std::size_t n = 0;
 
   int ret;
index a7a0ad83c65e21dc054f19d3d93509a916baf238..b5b8b1564ce3f94204d4489fcacbe891065ef21e 100644 (file)
@@ -42,7 +42,7 @@ void test01(int dummy, ...)
 #endif
 
 #if _GLIBCXX_HAVE_VFWSCANF
-  FILE* stream = 0;
+  FILE* stream = va_arg(arg, FILE*);
   const wchar_t* format1 = 0;
   int ret1;
   ret1 = std::tr1::vfwscanf(stream, format1, arg);