]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amdkfd: fix the warning for potential insecure string
authorSunil Khatri <sunil.khatri@amd.com>
Fri, 6 Mar 2026 07:23:30 +0000 (12:53 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 6 Mar 2026 21:33:55 +0000 (16:33 -0500)
Below is the warning thrown by the clang compiler:
linux/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:588:9: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
                                           stats_dir_filename);
                                           ^~~~~~~~~~~~~~~~~~
linux/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:588:9: note: treat the string as an argument to avoid this
                                           stats_dir_filename);
                                           ^
                                           "%s",
linux/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:635:18: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
                                           p->kobj, counters_dir_filename);
                                                    ^~~~~~~~~~~~~~~~~~~~~
linux/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:635:18: note: treat the string as an argument to avoid this
                                           p->kobj, counters_dir_filename);
                                                    ^
                                                    "%s",

Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
CC: Philip Yang <philip.yang@amd.com>
CC: Felix Kuehling <felix.kuehling@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_process.c

index 12e24fbf8c4630c8f42004eb9c80ba1e6524817e..a031166f270c8100f253fb35bbadd1fcf293f831 100644 (file)
@@ -585,7 +585,7 @@ static void kfd_procfs_add_sysfs_stats(struct kfd_process *p)
                ret = kobject_init_and_add(pdd->kobj_stats,
                                           &procfs_stats_type,
                                           p->kobj,
-                                          stats_dir_filename);
+                                          "%s", stats_dir_filename);
 
                if (ret) {
                        pr_warn("Creating KFD proc/stats_%s folder failed",
@@ -632,7 +632,7 @@ static void kfd_procfs_add_sysfs_counters(struct kfd_process *p)
                        return;
 
                ret = kobject_init_and_add(kobj_counters, &sysfs_counters_type,
-                                          p->kobj, counters_dir_filename);
+                                          p->kobj, "%s", counters_dir_filename);
                if (ret) {
                        pr_warn("Creating KFD proc/%s folder failed",
                                counters_dir_filename);