]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ARM: OMAP1: select CONFIG_GENERIC_IRQ_CHIP
authorArnd Bergmann <arnd@arndb.de>
Wed, 5 Feb 2025 12:11:33 +0000 (13:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Mar 2025 20:58:59 +0000 (21:58 +0100)
[ Upstream commit 98f3ab18a0a55aa1ff2cd6b74bd0c02c8f76f17e ]

When GENERIC_IRQ_CHIP is disabled, OMAP1 kernels fail to link:

arm-linux-gnueabi-ld: arch/arm/mach-omap1/irq.o: in function `omap1_init_irq':
irq.c:(.init.text+0x1e8): undefined reference to `irq_alloc_generic_chip'
arm-linux-gnueabi-ld: irq.c:(.init.text+0x228): undefined reference to `irq_setup_generic_chip'
arm-linux-gnueabi-ld: irq.c:(.init.text+0x2a8): undefined reference to `irq_gc_set_wake'
arm-linux-gnueabi-ld: irq.c:(.init.text+0x2b0): undefined reference to `irq_gc_mask_set_bit'
arm-linux-gnueabi-ld: irq.c:(.init.text+0x2b4): undefined reference to `irq_gc_mask_clr_bit'

This has apparently been the case for many years, but I never caught it
in randconfig builds until now, as there are dozens of other drivers
that also 'select GENERIC_IRQ_CHIP' and statistically there is almost
always one of them enabled.

Fixes: 55b447744389 ("ARM: OMAP1: Switch to use generic irqchip in preparation for sparse IRQ")
Link: https://lore.kernel.org/r/20250205121151.289535-1-arnd@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/mach-omap1/Kconfig

index 7ec7ada287e050692ee7421a87a1c3b7865cd8c9..16bf3bed38feba552466ae73abb1d2ef5f8ae1a5 100644 (file)
@@ -9,6 +9,7 @@ menuconfig ARCH_OMAP1
        select ARCH_OMAP
        select CLKSRC_MMIO
        select FORCE_PCI if PCCARD
+       select GENERIC_IRQ_CHIP
        select GPIOLIB
        help
          Support for older TI OMAP1 (omap7xx, omap15xx or omap16xx)