CVE-2023-34968: mdssvc: add missing "kMDSStoreMetaScopes" dict key in slrpc_fetch_pro...

We were adding the value, but not the key.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15388

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/source3/rpc_server/mdssvc/mdssvc.c b/source3/rpc_server/mdssvc/mdssvc.c
index 3af0a71a28eac7b9b43b5185477006abd7f5b8d2..72936a992890b5cf585faf2a065ea8738eb33941 100644 (file)
--- a/source3/rpc_server/mdssvc/mdssvc.c
+++ b/source3/rpc_server/mdssvc/mdssvc.c
@@ -743,6 +743,10 @@ static bool slrpc_fetch_properties(struct mds_ctx *mds_ctx,
        }
 
        /* kMDSStoreMetaScopes array */
+       result = dalloc_stradd(dict, "kMDSStoreMetaScopes");
+       if (result != 0) {
+               return false;
+       }
        array = dalloc_zero(dict, sl_array_t);
        if (array == NULL) {
                return NULL;