]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: rzg2l-cru: Simplify irq return value handling
authorJacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Thu, 26 Mar 2026 15:07:41 +0000 (16:07 +0100)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 19 May 2026 07:01:49 +0000 (09:01 +0200)
The rzg2l_cru_irq() irq handler uses a local variable to store the
handler return value.

Simplify it by using IRQ_NONE and IRQ_HANDLED.

Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c

index b6990466165e974731268746005d9681e971cf11..5185a547461d76a0d7da5c90b0938b1ffff56ccc 100644 (file)
@@ -591,16 +591,13 @@ static void rzg2l_cru_stop_streaming(struct rzg2l_cru_dev *cru)
 irqreturn_t rzg2l_cru_irq(int irq, void *data)
 {
        struct rzg2l_cru_dev *cru = data;
-       unsigned int handled = 0;
        u32 irq_status;
        u32 amnmbs;
        int slot;
 
        irq_status = rzg2l_cru_read(cru, CRUnINTS);
        if (!irq_status)
-               return IRQ_RETVAL(handled);
-
-       handled = 1;
+               return IRQ_NONE;
 
        rzg2l_cru_write(cru, CRUnINTS, rzg2l_cru_read(cru, CRUnINTS));
 
@@ -634,7 +631,7 @@ irqreturn_t rzg2l_cru_irq(int irq, void *data)
        /* Prepare for next frame */
        rzg2l_cru_fill_hw_slot(cru, slot);
 
-       return IRQ_RETVAL(handled);
+       return IRQ_HANDLED;
 }
 
 irqreturn_t rzg3e_cru_irq(int irq, void *data)