drm/amd/display: Silence link_dpms I2C retimer failures

Commit a4f01bf729b2 ("drm/amd/display: Refactor and fix link_dpms I2C")
had also changed the "Set retimer failed" messages from DC_LOG_DEBUG()
to DC_LOG_ERROR(). This unfortunately can create log spam.

Change those back to DC_LOG_DEBUG() only.

Fixes: a4f01bf729b2 ("drm/amd/display: Refactor and fix link_dpms I2C")
Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5520
Signed-off-by: Alan Swanson <reiver@improbability.net>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit da8609eef18b0a3490d0e1fa9440659fadc8194d)
Cc: stable@vger.kernel.org

diff --git a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
index 42e7f0e9b3ce47c261fd74a4a75efecf8db0a9c7..ca59977487994db81a7201fb2d3cd170009683de 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
+++ b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
@@ -384,7 +384,7 @@ static bool write_i2c_retimer_vga(
 
        for (size_t i = 0; i < ARRAY_SIZE(vga_data); i++) {
                if (!write_i2c_retimer_offset_value(link, address, vga_data[i][0], vga_data[i][1])) {
-                       DC_LOG_ERROR("Set retimer failed, vga index: %zu\n", i);
+                       DC_LOG_DEBUG("Set retimer failed, vga index: %zu\n", i);
                        return false;
                }
        }
@@ -405,7 +405,7 @@ static bool write_i2c_retimer_byte(
                return true;
 
        if (!write_i2c_retimer_offset_value(link, address, index, value)) {
-               DC_LOG_ERROR("Set retimer failed, 3g index: 0x%x, value: 0x%x\n", index, value);
+               DC_LOG_DEBUG("Set retimer failed, 3g index: 0x%x, value: 0x%x\n", index, value);
                return false;
        }
 
@@ -421,14 +421,14 @@ static bool write_i2c_retimer_byte(
                        if (!link_query_ddc_data(
                                        link->ddc, address, &offset, 1, &value, 1
                        )) {
-                               DC_LOG_ERROR("Set retimer failed, link_query_ddc_data\n");
+                               DC_LOG_DEBUG("Set retimer failed, link_query_ddc_data\n");
                                return false;
                        }
                }
 
                value |= apply_rx_tx_change;
                if (!write_i2c_retimer_offset_value(link, address, offset, value)) {
-                       DC_LOG_ERROR("Set retimer failed, 3g offset: 0x%x, value: 0x%x\n", offset, value);
+                       DC_LOG_DEBUG("Set retimer failed, 3g offset: 0x%x, value: 0x%x\n", offset, value);
                        return false;
                }
        }
@@ -449,7 +449,7 @@ static bool write_i2c_retimer_setting(
                uint8_t value = settings->reg_settings[i].i2c_reg_val;
 
                if (!write_i2c_retimer_byte(link, address, index, value)) {
-                       DC_LOG_ERROR("Set retimer failed, index: %zu\n", i);
+                       DC_LOG_DEBUG("Set retimer failed, index: %zu\n", i);
                        return false;
                }
        }
@@ -460,7 +460,7 @@ static bool write_i2c_retimer_setting(
                        uint8_t value = settings->reg_settings_6g[i].i2c_reg_val;
 
                        if (!write_i2c_retimer_byte(link, address, index, value)) {
-                               DC_LOG_ERROR("Set retimer failed, 6g index: %zu\n", i);
+                               DC_LOG_DEBUG("Set retimer failed, 6g index: %zu\n", i);
                                return false;
                        }
                }
@@ -492,7 +492,7 @@ static bool write_i2c_default_retimer_setting(
 
        for (size_t i = 0; i < ARRAY_SIZE(data); i++) {
                if (!write_i2c_retimer_offset_value(link, address, data[i][0], data[i][1])) {
-                       DC_LOG_ERROR("Set default retimer failed, index: %zu\n", i);
+                       DC_LOG_DEBUG("Set default retimer failed, index: %zu\n", i);
                        return false;
                }
        }
@@ -524,7 +524,7 @@ static bool write_i2c_redriver_setting(
        );
 
        if (!success)
-               DC_LOG_ERROR("Set redriver failed");
+               DC_LOG_DEBUG("Set redriver failed");
        return success;
 }