spi: amlogic-spisg: initialize completion before requesting IRQ

Move init_completion(&spisg->completion) to before devm_request_irq()
to avoid a potential race condition where an interrupt could fire
before the completion structure is initialized.

Fixes: cef9991e04ae ("spi: Add Amlogic SPISG driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260428-amlogic-spisg-v1-1-8eecc3b446d6@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-amlogic-spisg.c b/drivers/spi/spi-amlogic-spisg.c
index 19c5eba412ef4ca4de12a61c2c1e44f4f9f85762..f9de2d2c92132b238c22bafc8a25dc88e2815ea7 100644 (file)
--- a/drivers/spi/spi-amlogic-spisg.c
+++ b/drivers/spi/spi-amlogic-spisg.c
@@ -794,6 +794,7 @@ static int aml_spisg_probe(struct platform_device *pdev)
 
        dma_set_max_seg_size(&pdev->dev, SPISG_BLOCK_MAX);
 
+       init_completion(&spisg->completion);
        ret = devm_request_irq(&pdev->dev, irq, aml_spisg_irq, 0, NULL, spisg);
        if (ret) {
                dev_err(&pdev->dev, "irq request failed\n");
@@ -806,8 +807,6 @@ static int aml_spisg_probe(struct platform_device *pdev)
                goto out_clk;
        }
 
-       init_completion(&spisg->completion);
-
        pm_runtime_put(&spisg->pdev->dev);
 
        return 0;