]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net/mlx5e: Remove redundant UDP length adjustment with GSO_PARTIAL
authorGal Pressman <gal@nvidia.com>
Sun, 25 Jan 2026 12:16:48 +0000 (14:16 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 28 Jan 2026 01:30:51 +0000 (17:30 -0800)
GSO_PARTIAL now takes care of updating the UDP header length,
mlx5e_udp_gso_handle_tx_skb() is redundant, remove it.

Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20260125121649.778086-3-gal@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h

index 8bef99e8367efb406280f967aaa14cdb4a81493a..b526b3898c22e08d04e835ebb951cfbf36588a08 100644 (file)
@@ -100,20 +100,6 @@ static inline bool mlx5_geneve_tx_allowed(struct mlx5_core_dev *mdev)
 
 #endif /* CONFIG_GENEVE */
 
-static inline void
-mlx5e_udp_gso_handle_tx_skb(struct sk_buff *skb)
-{
-       int payload_len = skb_shinfo(skb)->gso_size + sizeof(struct udphdr);
-       struct udphdr *udphdr;
-
-       if (skb->encapsulation)
-               udphdr = (struct udphdr *)skb_inner_transport_header(skb);
-       else
-               udphdr = udp_hdr(skb);
-
-       udphdr->len = htons(payload_len);
-}
-
 struct mlx5e_accel_tx_state {
 #ifdef CONFIG_MLX5_EN_TLS
        struct mlx5e_accel_tx_tls_state tls;
@@ -131,9 +117,6 @@ static inline bool mlx5e_accel_tx_begin(struct net_device *dev,
                                        struct sk_buff *skb,
                                        struct mlx5e_accel_tx_state *state)
 {
-       if (skb_is_gso(skb) && skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4)
-               mlx5e_udp_gso_handle_tx_skb(skb);
-
 #ifdef CONFIG_MLX5_EN_TLS
        /* May send WQEs. */
        if (tls_is_skb_tx_device_offloaded(skb))