lib:util: Fix size of tmp array

lib/util/util.c: In function ‘dump_data_block16’:
lib/util/util.c:503:40: error: ‘%04zX’ directive output may be truncated
writing between 4 and 16 bytes into a region of size 15
[-Werror=format-truncation=]
  503 |         snprintf(tmp, sizeof(tmp), "%s[%04zX]", prefix, idx);
      |                                        ^~~~~

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/lib/util/util.c b/lib/util/util.c
index 9df9837c85076045d51c2ad53307a4af604b7734..75a17d81b2269e958a187e797855efff852b92d2 100644 (file)
--- a/lib/util/util.c
+++ b/lib/util/util.c
@@ -495,7 +495,9 @@ static void dump_data_block16(const char *prefix, size_t idx,
                              void (*cb)(const char *buf, void *private_data),
                              void *private_data)
 {
-       char tmp[16];
+       size_t prefix_len = strlen(prefix);
+       /* 16 (=%04zX) + 2 (=[]) + 1 (='\0') => 19 */
+       char tmp[prefix_len + 19];
        size_t i;
 
        SMB_ASSERT(len <= 16);