]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
soc: apple: rtkit: Use high prio work queue
authorJanne Grunau <j@jannau.net>
Wed, 26 Feb 2025 19:00:05 +0000 (19:00 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:40:10 +0000 (14:40 +0200)
[ Upstream commit 22af2fac88fa5dbc310bfe7d0b66d4de3ac47305 ]

rtkit messages as communication with the DCP firmware for framebuffer
swaps or input events are time critical so use WQ_HIGHPRI to prevent
user space CPU load to increase latency.
With kwin_wayland 6's explicit sync mode user space load was able to
delay the IOMFB rtkit communication enough to miss vsync for surface
swaps. Minimal test scenario is constantly resizing a glxgears
Xwayland window.

Signed-off-by: Janne Grunau <j@jannau.net>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Link: https://lore.kernel.org/r/20250226-apple-soc-misc-v2-3-c3ec37f9021b@svenpeter.dev
Signed-off-by: Sven Peter <sven@svenpeter.dev>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/apple/rtkit.c

index 8ec74d7539eb4fd57ce9f84642d8fc5dbf474cf0..1ec0c3ba0be22ed04df362b0bffe08b58e6b09d1 100644 (file)
@@ -731,7 +731,7 @@ static struct apple_rtkit *apple_rtkit_init(struct device *dev, void *cookie,
        rtk->mbox_cl.rx_callback = &apple_rtkit_rx;
        rtk->mbox_cl.tx_done = &apple_rtkit_tx_done;
 
-       rtk->wq = alloc_ordered_workqueue("rtkit-%s", WQ_MEM_RECLAIM,
+       rtk->wq = alloc_ordered_workqueue("rtkit-%s", WQ_HIGHPRI | WQ_MEM_RECLAIM,
                                          dev_name(rtk->dev));
        if (!rtk->wq) {
                ret = -ENOMEM;