]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: adc: at91-sama5d2_adc: no devm for nvmem_cell_get
authorRosen Penev <rosenp@gmail.com>
Wed, 4 Mar 2026 04:18:43 +0000 (20:18 -0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 14 Mar 2026 12:10:21 +0000 (12:10 +0000)
There is absolutely no reason to pospone cleanup of this post driver
removal. Just do it immediately.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Eugen Hristev <eugen.hristev@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/at91-sama5d2_adc.c

index 69bb49434f90c1175d1c27631f1d44478277a3ba..255970b2e747965f91b934b68c8de80b10f49c81 100644 (file)
@@ -2259,7 +2259,7 @@ static int at91_adc_temp_sensor_init(struct at91_adc_state *st,
                return 0;
 
        /* Get the calibration data from NVMEM. */
-       temp_calib = devm_nvmem_cell_get(dev, "temperature_calib");
+       temp_calib = nvmem_cell_get(dev, "temperature_calib");
        if (IS_ERR(temp_calib)) {
                ret = PTR_ERR(temp_calib);
                if (ret != -ENOENT)
@@ -2268,6 +2268,7 @@ static int at91_adc_temp_sensor_init(struct at91_adc_state *st,
        }
 
        buf = nvmem_cell_read(temp_calib, &len);
+       nvmem_cell_put(temp_calib);
        if (IS_ERR(buf)) {
                dev_err(dev, "Failed to read calibration data!\n");
                return PTR_ERR(buf);