]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virSecuritySELinuxTransactionCommit: Don't mask error
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 13 Nov 2018 15:45:52 +0000 (16:45 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 13 Nov 2018 17:33:58 +0000 (18:33 +0100)
In 4674fc6afd6 I've implemented transactions for selinux driver.
Well, now that I am working in this area I've noticed a subtle
bug: @ret is initialized to 0 instead of -1. Facepalm.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com>
src/security/security_selinux.c

index 467d1e6bfe287f92df89ca8f1ae38ba4941eef38..c09404f6f833ccb688e2f8515713b2e17d8e934c 100644 (file)
@@ -1091,7 +1091,7 @@ virSecuritySELinuxTransactionCommit(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
                                     pid_t pid)
 {
     virSecuritySELinuxContextListPtr list;
-    int ret = 0;
+    int ret = -1;
 
     list = virThreadLocalGet(&contextList);
     if (!list)