]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix and call tsig_badsig unit test
authorMark Andrews <marka@isc.org>
Fri, 23 Jan 2026 03:30:44 +0000 (14:30 +1100)
committerMark Andrews <marka@isc.org>
Fri, 23 Jan 2026 14:25:55 +0000 (01:25 +1100)
tests/dns/tsig_test.c

index b07dcd27abebb891ebed0c165d9e8d54acb5e8c8..ca93875157805bdc356d1ec80663171657d799a9 100644 (file)
@@ -419,7 +419,16 @@ tsig_tcp(isc_stdtime_t now, isc_result_t expected_result, bool mangle_sig) {
                assert_int_equal(msg->verified_sig, 1);
                assert_int_equal(msg->tsigstatus, dns_tsigerror_badtime);
                break;
+       case DNS_R_TSIGVERIFYFAILURE:
+               assert_int_equal(result, DNS_R_TSIGVERIFYFAILURE);
+               assert_int_equal(msg->verified_sig, 0);
+               assert_int_equal(msg->tsigstatus, dns_tsigerror_badsig);
+               break;
        default:
+               if (debug) {
+                       fprintf(stderr, "# result = %s\n",
+                               isc_result_totext(result));
+               }
                UNREACHABLE();
        }
 
@@ -471,7 +480,7 @@ ISC_RUN_TEST_IMPL(tsig_badtime) {
 }
 
 ISC_RUN_TEST_IMPL(tsig_badsig) {
-       tsig_tcp(isc_stdtime_now(), DNS_R_TSIGERRORSET, true);
+       tsig_tcp(isc_stdtime_now(), DNS_R_TSIGVERIFYFAILURE, true);
 }
 
 /* Tests the dns__tsig_algvalid function */
@@ -490,9 +499,10 @@ ISC_RUN_TEST_IMPL(algvalid) {
 }
 
 ISC_TEST_LIST_START
-ISC_TEST_ENTRY(tsig_tcp)
-ISC_TEST_ENTRY(tsig_badtime)
 ISC_TEST_ENTRY(algvalid)
+ISC_TEST_ENTRY(tsig_badsig)
+ISC_TEST_ENTRY(tsig_badtime)
+ISC_TEST_ENTRY(tsig_tcp)
 ISC_TEST_LIST_END
 
 ISC_TEST_MAIN