cgsnapshot: Fixed file descriptor leak when enumerating controllers

Close the iterators on error. In addition, handling when FL_SILENT flag is
on/off should be the same, except the error output.

Signed-off-by: Jan Safranek <jsafrane@redhat.com>

diff --git a/src/tools/cgsnapshot.c b/src/tools/cgsnapshot.c
index a24dae7081fab63f0a3d071b9f86647a2bdbb7ef..51194f6749297ce09fc2a71b9363a0f7731db374 100644 (file)
--- a/src/tools/cgsnapshot.c
+++ b/src/tools/cgsnapshot.c
@@ -659,7 +659,6 @@ static int parse_mountpoints(cont_name_t cont_names[CG_CONTROLLER_MAX],
                        fprintf(stderr,
                                "E: in get next controller %s\n",
                                cgroup_strerror(ret));
-                       return ret;
                }
                final_ret = ret;
        }
@@ -681,7 +680,6 @@ static int parse_mountpoints(cont_name_t cont_names[CG_CONTROLLER_MAX],
                        fprintf(stderr,
                                "E: in get next controller %s\n",
                                cgroup_strerror(ret));
-                       return ret;
                }
                final_ret = ret;
        }