]> git.ipfire.org Git - thirdparty/bird.git/commitdiff
Replace goto with else
authorIgor Putovny <igor.putovny@nic.cz>
Fri, 10 May 2024 10:33:56 +0000 (12:33 +0200)
committerIgor Putovny <igor.putovny@nic.cz>
Thu, 30 May 2024 10:30:00 +0000 (12:30 +0200)
proto/aggregator/aggregator.c

index a29c33351b9476770bf1b853aa533fca71b3e2da..311a237dac64b68c1e3b78fbe31179f60cb2fa24 100644 (file)
@@ -582,30 +582,30 @@ third_pass(struct trie_node *node)
     assert(node->potential_buckets[0] != NULL);
     //assert(node->bucket != NULL);
     node->bucket = node->potential_buckets[0];
-    goto descent;
-  }
-
-  const struct aggregator_bucket *inherited_bucket = get_ancestor_bucket(node);
-
-  /*
-   * If bucket inherited from ancestor is one of potential buckets of this node,
-   * then this node doesn't need bucket because it inherits one.
-   */
-  if (is_bucket_potential(node, inherited_bucket))
-  {
-    node->bucket = NULL;
-    remove_potential_buckets(node);
   }
   else
   {
-    assert(node->potential_buckets_count > 0);
-    node->bucket = node->potential_buckets[0];
+    const struct aggregator_bucket *inherited_bucket = get_ancestor_bucket(node);
+
+    /*
+     * If bucket inherited from ancestor is one of potential buckets of this node,
+     * then this node doesn't need bucket because it inherits one.
+     */
+    if (is_bucket_potential(node, inherited_bucket))
+    {
+      node->bucket = NULL;
+      remove_potential_buckets(node);
+    }
+    else
+    {
+      assert(node->potential_buckets_count > 0);
+      node->bucket = node->potential_buckets[0];
+    }
   }
 
   /* Preorder traversal */
-  descent:
-    third_pass(node->child[0]);
-    third_pass(node->child[1]);
+  third_pass(node->child[0]);
+  third_pass(node->child[1]);
 
   /* Leaves with no assigned bucket are removed */
   if (node->bucket == NULL && is_leaf(node))