2003-03-31 Havoc Pennington <hp@redhat.com>

	* dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
	(_dbus_listen_unix_socket): fix off-by-one error in null
	termination spotted by Nalin

diff --git a/ChangeLog b/ChangeLog
index 717ee488012a4846f78fa2872d521e551f1d0907..4e987f41d3cb027c1aeaaad489115758e5a534e3 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2003-03-31  Havoc Pennington  <hp@redhat.com>
+
+       * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket) 
+       (_dbus_listen_unix_socket): fix off-by-one error in null
+       termination spotted by Nalin
+
 2003-03-31  Havoc Pennington  <hp@redhat.com>
 
        * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting

diff --git a/dbus/dbus-sysdeps.c b/dbus/dbus-sysdeps.c
index f551c4bfff33da3c0cb942fdb57e5b56106aeddd..cab970a0642f1a41e55536136cbfe5014f6a9cff 100644 (file)
--- a/dbus/dbus-sysdeps.c
+++ b/dbus/dbus-sysdeps.c
@@ -346,7 +346,7 @@ _dbus_connect_unix_socket (const char     *path,
   _DBUS_ZERO (addr);
   addr.sun_family = AF_UNIX;
   strncpy (addr.sun_path, path, _DBUS_MAX_SUN_PATH_LENGTH);
-  addr.sun_path[_DBUS_MAX_SUN_PATH_LENGTH] = '\0';
+  addr.sun_path[_DBUS_MAX_SUN_PATH_LENGTH-1] = '\0';
   
   if (connect (fd, (struct sockaddr*) &addr, sizeof (addr)) < 0)
     {      
@@ -405,7 +405,7 @@ _dbus_listen_unix_socket (const char     *path,
   _DBUS_ZERO (addr);
   addr.sun_family = AF_UNIX;
   strncpy (addr.sun_path, path, _DBUS_MAX_SUN_PATH_LENGTH);
-  addr.sun_path[_DBUS_MAX_SUN_PATH_LENGTH] = '\0';
+  addr.sun_path[_DBUS_MAX_SUN_PATH_LENGTH-1] = '\0';
   
   if (bind (listen_fd, (struct sockaddr*) &addr, SUN_LEN (&addr)) < 0)
     {