]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
bio: fix memcpy corruption in bio_copy_user_iov()
authorFUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Tue, 28 Apr 2009 18:24:29 +0000 (20:24 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 8 May 2009 22:45:04 +0000 (15:45 -0700)
commit 69838727bcd819a8fd73a88447801221788b0c6d upstream.

st driver uses blk_rq_map_user() in order to just build a request out
of page frames. In this case, map_data->offset is a non zero value and
iov[0].iov_base is NULL. We need to increase nr_pages for that.

Cc: stable@kernel.org
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/bio.c

index d4f06327c810b163e2165455f6c0466c98b42f25..bfdfe57ae3cc464569f0d866db09f107a5e5c665 100644 (file)
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -806,6 +806,9 @@ struct bio *bio_copy_user_iov(struct request_queue *q,
                len += iov[i].iov_len;
        }
 
+       if (offset)
+               nr_pages++;
+
        bmd = bio_alloc_map_data(nr_pages, iov_count, gfp_mask);
        if (!bmd)
                return ERR_PTR(-ENOMEM);