]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
lib/test_meminit: use && for bools
authorAlexander Potapenko <glider@google.com>
Mon, 4 May 2026 10:06:37 +0000 (12:06 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 2 Jun 2026 22:22:15 +0000 (15:22 -0700)
As pointed out by Dan Carpenter, test_kmemcache() was using a bitwise AND
on two bools instead of a boolean AND.  Fix this for the sake of code
cleanliness.

Link: https://lore.kernel.org/20260504100637.1535762-1-glider@google.com
Fixes: 5015a300a522 ("lib: introduce test_meminit module")
Signed-off-by: Alexander Potapenko <glider@google.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/kernel-janitors/afOcIan1ap9kD26M@stanley.mountain/
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/test_meminit.c

index 6298f66c964bb10a41bc31bfdc7e6dff5b92339f..d028a6552cd61c3bda1e3935a82fd72290bff31b 100644 (file)
@@ -387,7 +387,7 @@ static int __init test_kmemcache(int *total_failures)
                        ctor = flags & 1;
                        rcu = flags & 2;
                        zero = flags & 4;
-                       if (ctor & zero)
+                       if (ctor && zero)
                                continue;
                        num_tests += do_kmem_cache_size(size, ctor, rcu, zero,
                                                        &failures);