]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: qcom: venus: Fix uninitialized variable warning
authorNas Chung <nas.chung@chipsnmedia.com>
Thu, 25 Jul 2024 06:10:33 +0000 (15:10 +0900)
committerHans Verkuil <hverkuil@xs4all.nl>
Mon, 7 Apr 2025 11:28:25 +0000 (13:28 +0200)
Avoid uninitialized variable when both V4L2_TYPE_IS_OUTPUT() and
V4L2_TYPE_IS_CAPTURE() return false.

Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/qcom/venus/vdec.c

index 9f82882b77bcc520d5c4492bd9fe121a9b5dfc1d..39d0556d7237d7906a9ec5dc73b2f8536faf34bc 100644 (file)
@@ -154,14 +154,14 @@ find_format_by_index(struct venus_inst *inst, unsigned int index, u32 type)
                return NULL;
 
        for (i = 0; i < size; i++) {
-               bool valid;
+               bool valid = false;
 
                if (fmt[i].type != type)
                        continue;
 
                if (V4L2_TYPE_IS_OUTPUT(type)) {
                        valid = venus_helper_check_codec(inst, fmt[i].pixfmt);
-               } else if (V4L2_TYPE_IS_CAPTURE(type)) {
+               } else {
                        valid = venus_helper_check_format(inst, fmt[i].pixfmt);
 
                        if (fmt[i].pixfmt == V4L2_PIX_FMT_QC10C &&