More leak pluggin. This one fixes bug 39526.

Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net

diff --git a/show_activity.cgi b/show_activity.cgi
index d6e388afc1ad3aa39f3d6fc2eae61f5592db4450..fccc21cd4babffbe7bfd3ac94e44cfc18fcaa80f 100755 (executable)
--- a/show_activity.cgi
+++ b/show_activity.cgi
@@ -19,21 +19,40 @@
 # Rights Reserved.
 #
 # Contributor(s): Terry Weissman <terry@mozilla.org>
+#                 Myk Melez <myk@mozilla.org>
 
 use diagnostics;
 use strict;
 
 require "CGI.pl";
 
+ConnectToDatabase();
+
+######################################################################
+# Begin Data/Security Validation
+######################################################################
+
+# Check whether or not the user is currently logged in. This function 
+# sets the value of $::usergroupset, the binary number that records
+# the set of groups to which the user belongs and which we can use
+# to determine whether or not the user is authorized to access this bug.
+quietly_check_login();
+
+# Make sure the bug ID is a positive integer representing an existing
+# bug that the user is authorized to access.
+ValidateBugID($::FORM{'id'});
+
+######################################################################
+# End Data/Security Validation
+######################################################################
+
 print "Content-type: text/html\n\n";
 
 PutHeader("Changes made to bug $::FORM{'id'}", "Activity log",
           "Bug $::FORM{'id'}");
 
-ConnectToDatabase();
-
 DumpBugActivity($::FORM{'id'});
 
-print "<hr><a href=show_bug.cgi?id=$::FORM{'id'}>Back to bug $::FORM{'id'}</a>\n";
+print qq|<hr><a href="show_bug.cgi?id=$::FORM{'id'}">Back to bug $::FORM{'id'}</a>\n|;
 
 PutFooter();