]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemublocktest: Don't leak 'disk' in testQemuImageCreateLoadDiskXML
authorPeter Krempa <pkrempa@redhat.com>
Mon, 25 Oct 2021 14:11:49 +0000 (16:11 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 25 Oct 2021 14:11:49 +0000 (16:11 +0200)
The function returns only the source portion but forgot to free the disk
wrapper.

Fixes: 9696427ad67196
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
tests/qemublocktest.c

index 0176fbd3f4791aa00381cf4c339595e67977709f..9d3c2fe6b0e2a2f16edf5112873311ce537d0104 100644 (file)
@@ -473,7 +473,7 @@ testQemuImageCreateLoadDiskXML(const char *name,
                                virDomainXMLOption *xmlopt)
 
 {
-    virDomainDiskDef *disk = NULL;
+    g_autoptr(virDomainDiskDef) disk = NULL;
     g_autofree char *xmlpath = NULL;
     g_autofree char *xmlstr = NULL;
 
@@ -490,7 +490,7 @@ testQemuImageCreateLoadDiskXML(const char *name,
     if (qemuDomainDeviceDiskDefPostParse(disk, 0) < 0)
         return NULL;
 
-    return disk->src;
+    return g_steal_pointer(&disk->src);
 }