]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Revert "qemu: Obtain reference on monConfig"
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 8 Oct 2019 07:49:18 +0000 (09:49 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 9 Oct 2019 08:38:05 +0000 (10:38 +0200)
This reverts commit a5a777a8bae61cb9e41c4dcd12d2962ad1a65a0d.

After previous commit the domain won't disappear while connecting
to monitor. There's no need to ref monitor config then.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_process.c

index 0d20427b9f0ee6a48200511e253e18487423ceb1..ba1ccf992a55587406c0ba7c5cff958ff573a3df 100644 (file)
@@ -1941,7 +1941,6 @@ qemuConnectMonitor(virQEMUDriverPtr driver, virDomainObjPtr vm, int asyncJob,
     qemuDomainObjPrivatePtr priv = vm->privateData;
     qemuMonitorPtr mon = NULL;
     unsigned long long timeout = 0;
-    virDomainChrSourceDefPtr monConfig;
 
     if (qemuSecuritySetDaemonSocketLabel(driver->securityManager, vm->def) < 0) {
         VIR_ERROR(_("Failed to set security context for monitor for %s"),
@@ -1956,10 +1955,9 @@ qemuConnectMonitor(virQEMUDriverPtr driver, virDomainObjPtr vm, int asyncJob,
     timeout = vm->def->mem.total_memory / (1024 * 1024);
 
     ignore_value(virTimeMillisNow(&priv->monStart));
-    monConfig = virObjectRef(priv->monConfig);
 
     mon = qemuMonitorOpen(vm,
-                          monConfig,
+                          priv->monConfig,
                           retry,
                           timeout,
                           &monitorCallbacks,
@@ -1973,7 +1971,6 @@ qemuConnectMonitor(virQEMUDriverPtr driver, virDomainObjPtr vm, int asyncJob,
                                 qemuProcessMonitorLogFree);
     }
 
-    virObjectUnref(monConfig);
     priv->monStart = 0;
     priv->mon = mon;