]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Error messages should end with a newline character.
authorNeilBrown <neilb@suse.com>
Fri, 4 Aug 2017 05:30:02 +0000 (15:30 +1000)
committerJes Sorensen <jsorensen@fb.com>
Wed, 16 Aug 2017 12:25:07 +0000 (08:25 -0400)
Add "\n" to the end of error messages which don't already
have one.  Also spell "opened" correctly.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Build.c
Grow.c
Manage.c
mdopen.c

diff --git a/Build.c b/Build.c
index 70ba068437961aece4fc248611a4c9a4969e1bd1..962c2e3776b91ccb15135b9c0cff91f322a8c9fe 100644 (file)
--- a/Build.c
+++ b/Build.c
@@ -181,7 +181,7 @@ int Build(char *mddev, struct mddev_dev *devlist,
                        int major = BITMAP_MAJOR_HI;
 #if 0
                        if (s->bitmap_chunk == UnSet) {
-                               pr_err("%s cannot be openned.", s->bitmap_file);
+                               pr_err("%s cannot be opened.\n", s->bitmap_file);
                                goto abort;
                        }
 #endif
@@ -193,7 +193,7 @@ int Build(char *mddev, struct mddev_dev *devlist,
                        }
                        bitmap_fd = open(s->bitmap_file, O_RDWR);
                        if (bitmap_fd < 0) {
-                               pr_err("%s cannot be openned.", s->bitmap_file);
+                               pr_err("%s cannot be opened.\n", s->bitmap_file);
                                goto abort;
                        }
                }
diff --git a/Grow.c b/Grow.c
index b1cb3069a3145840a901726e6f344a66236f271c..534ba801999838b0b3b61c452f8f61807deb1379 100644 (file)
--- a/Grow.c
+++ b/Grow.c
@@ -3202,7 +3202,7 @@ static int reshape_array(char *container, int fd, char *devname,
 
                if (info2) {
                        if (sysfs_init(info2, fd, st->devnm)) {
-                               pr_err("unable to initialize sysfs for %s",
+                               pr_err("unable to initialize sysfs for %s\n",
                                       st->devnm);
                                free(info2);
                                goto release;
@@ -5146,7 +5146,7 @@ int Grow_continue_command(char *devname, int fd,
                }
 
                if (sysfs_init(content, fd2, mdstat->devnm)) {
-                       pr_err("Unable to initialize sysfs for %s, Grow cannot continue",
+                       pr_err("Unable to initialize sysfs for %s, Grow cannot continue.\n",
                               mdstat->devnm);
                        ret_val = 1;
                        close(fd2);
index b82a7293f0f14da0398236690e07442a4c46ef0a..871d342872bbe8d1992f29895a8c1e6e7dc6fd82 100644 (file)
--- a/Manage.c
+++ b/Manage.c
@@ -1417,7 +1417,7 @@ int Manage_subdevs(char *devname, int fd,
                        }
                        add_devlist = conf_get_devs();
                        if (add_devlist == NULL) {
-                               pr_err("no devices to scan for missing members.");
+                               pr_err("no devices to scan for missing members.\n");
                                continue;
                        }
                        for (dp = &add_devlist; *dp; dp = & (*dp)->next)
index c4f1c12c2dcd8a9ce574ef3d77147826e96adbd3..3c0052f2db23a000362a05e838bd735ee65ccc45 100644 (file)
--- a/mdopen.c
+++ b/mdopen.c
@@ -198,7 +198,7 @@ int create_mddev(char *dev, char *name, int autof, int trustworthy,
                        return -1;
                }
                if (cname[0] == 0) {
-                       pr_err("%s is an invalid name for an md device (empty!).", dev);
+                       pr_err("%s is an invalid name for an md device (empty!).\n", dev);
                        return -1;
                }
                if (num < 0) {