tools/power turbostat: Use strtoul() for iteration parsing

Replace strtod() with strtoul() and check errno for -n/-N options, since
num_iterations and header_iterations are unsigned long counters. Reject
zero and conversion errors; negative inputs wrap to large positive values
per standard unsigned semantics.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 5239fd971b66a638f854e59432ec391b2699364f..b8cbbff95e845ef839b249339736b3e7d62b0c7e 100644 (file)
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -11536,18 +11536,20 @@ void cmdline(int argc, char **argv)
                        /* Parsed earlier */
                        break;
                case 'n':
-                       num_iterations = strtod(optarg, NULL);
+                       num_iterations = strtoul(optarg, NULL, 0);
+                       errno = 0;
 
-                       if (num_iterations <= 0) {
-                               fprintf(outf, "iterations %d should be positive number\n", num_iterations);
+                       if (errno || num_iterations == 0) {
+                               fprintf(outf, "invalid iteration count: %s\n", optarg);
                                exit(2);
                        }
                        break;
                case 'N':
-                       header_iterations = strtod(optarg, NULL);
+                       header_iterations = strtoul(optarg, NULL, 0);
+                       errno = 0;
 
-                       if (header_iterations <= 0) {
-                               fprintf(outf, "iterations %d should be positive number\n", header_iterations);
+                       if (errno || header_iterations == 0) {
+                               fprintf(outf, "invalid header iteration count: %s\n", optarg);
                                exit(2);
                        }
                        break;