]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
atm: idt77252: Use sb_pool_remove()
authorThomas Fourier <fourier.thomas@gmail.com>
Mon, 5 Jan 2026 21:29:15 +0000 (22:29 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 7 Jan 2026 02:04:59 +0000 (18:04 -0800)
Replacing the manual pool remove with the dedicated function.  This is
safer and more consistent with the rest of the code[1].

[1]; https://lore.kernel.org/all/20250625094013.GL1562@horms.kernel.org/

Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Link: https://patch.msgid.link/20260105212916.26678-2-fourier.thomas@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/atm/idt77252.c

index f2e91b7d79f01049144652251c1b86a60a9ff9b9..888695ccc2a7b6358387f987cab9871a8c25ec04 100644 (file)
@@ -1844,7 +1844,6 @@ add_rx_skb(struct idt77252_dev *card, int queue,
 {
        struct sk_buff *skb;
        dma_addr_t paddr;
-       u32 handle;
 
        while (count--) {
                skb = dev_alloc_skb(size);
@@ -1876,8 +1875,7 @@ outunmap:
                         skb_end_pointer(skb) - skb->data, DMA_FROM_DEVICE);
 
 outpoolrm:
-       handle = IDT77252_PRV_POOL(skb);
-       card->sbpool[POOL_QUEUE(handle)].skb[POOL_INDEX(handle)] = NULL;
+       sb_pool_remove(card, skb);
 
 outfree:
        dev_kfree_skb(skb);