]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
CMS_verify(): Fix leak of tmpin in an error path
authoropenssl-machine <openssl-machine@openssl.org>
Mon, 23 Mar 2026 08:09:03 +0000 (09:09 +0100)
committerTomas Mraz <tomas@openssl.foundation>
Fri, 27 Mar 2026 16:44:04 +0000 (17:44 +0100)
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.foundation>
MergeDate: Fri Mar 27 16:43:44 2026
(Merged from https://github.com/openssl/openssl/pull/30535)

(cherry picked from commit 2036e997430f4bee75d3a60301f7ecc8c2e66198)

crypto/cms/cms_smime.c

index 6ddcec615737545be858d423e520c3f254e595dd..659c033482b3864e586600ad57d2264a39ae42dd 100644 (file)
@@ -474,8 +474,10 @@ err:
     } else {
         if (dcont && (tmpin == dcont))
             do_free_upto(cmsbio, dcont);
-        else
+        else if (cmsbio != NULL)
             BIO_free_all(cmsbio);
+        else
+            BIO_free(tmpin);
     }
 
     if (out != tmpout)