]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: rc5t583: remove unneeded call to platform_set_drvdata()
authorAndrei Coardos <aboutphysycs@gmail.com>
Fri, 28 Jul 2023 18:20:09 +0000 (21:20 +0300)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 1 Aug 2023 19:26:48 +0000 (21:26 +0200)
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-rc5t583.c

index 4fae3ebea7909853b5a5fa6fdf1a4a27bf13583b..c34dcadaee36d5fb775d4aaa8c8f8b275f4e2382 100644 (file)
@@ -121,8 +121,6 @@ static int rc5t583_gpio_probe(struct platform_device *pdev)
        if (pdata && pdata->gpio_base)
                rc5t583_gpio->gpio_chip.base = pdata->gpio_base;
 
-       platform_set_drvdata(pdev, rc5t583_gpio);
-
        return devm_gpiochip_add_data(&pdev->dev, &rc5t583_gpio->gpio_chip,
                                      rc5t583_gpio);
 }