]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/panel: mantix: Drop the shutdown callback
authorSebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Mon, 16 Feb 2026 17:50:18 +0000 (18:50 +0100)
committerNeil Armstrong <neil.armstrong@linaro.org>
Tue, 10 Mar 2026 13:26:00 +0000 (14:26 +0100)
It's the responsibility of the DRM modeset driver to unprepare
and disable the panel. Doing so here leads to regulator underflows.

Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20260216-mantix-shutdown-v1-1-d2e93a8ccc4c@puri.sm
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c

index 13352cb4ad774156e759ddc846cc41c0cdaaf03d..02e203e9f41ad3316115969ce0835b896ca2eed5 100644 (file)
@@ -295,20 +295,10 @@ static int mantix_probe(struct mipi_dsi_device *dsi)
        return 0;
 }
 
-static void mantix_shutdown(struct mipi_dsi_device *dsi)
-{
-       struct mantix *ctx = mipi_dsi_get_drvdata(dsi);
-
-       drm_panel_unprepare(&ctx->panel);
-       drm_panel_disable(&ctx->panel);
-}
-
 static void mantix_remove(struct mipi_dsi_device *dsi)
 {
        struct mantix *ctx = mipi_dsi_get_drvdata(dsi);
 
-       mantix_shutdown(dsi);
-
        mipi_dsi_detach(dsi);
        drm_panel_remove(&ctx->panel);
 }
@@ -323,7 +313,6 @@ MODULE_DEVICE_TABLE(of, mantix_of_match);
 static struct mipi_dsi_driver mantix_driver = {
        .probe  = mantix_probe,
        .remove = mantix_remove,
-       .shutdown = mantix_shutdown,
        .driver = {
                .name = DRV_NAME,
                .of_match_table = mantix_of_match,