media: pci: zoran: fix potential memory leak in zoran_probe()

The memory allocated for codec in videocodec_attach() is not freed in
one of the error paths, due to an incorrect goto label. Fix the label
to free it on error.

Fixes: 8f7cc5c0b0eb ("media: staging: media: zoran: introduce zoran_i2c_init")
Cc: stable@vger.kernel.org
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/pci/zoran/zoran_card.c b/drivers/media/pci/zoran/zoran_card.c
index d81facf735d92069297c8d52eeb2359a22f040cd..f707bdc1fb0f1dfa04645682679e05159cae80ee 100644 (file)
--- a/drivers/media/pci/zoran/zoran_card.c
+++ b/drivers/media/pci/zoran/zoran_card.c
@@ -1373,7 +1373,7 @@ static int zoran_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                }
                if (zr->codec->type != zr->card.video_codec) {
                        pci_err(pdev, "%s - wrong codec\n", __func__);
-                       goto zr_unreg_videocodec;
+                       goto zr_detach_codec;
                }
        }
        if (zr->card.video_vfe != 0) {