]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
storage: Resolve Coverity UNUSED_VALUE
authorJohn Ferlan <jferlan@redhat.com>
Thu, 4 Sep 2014 13:37:21 +0000 (09:37 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Thu, 11 Sep 2014 11:33:19 +0000 (07:33 -0400)
Since cd4d547576a4f0371d1d4d4e0ca6db124c5ba257

Coverity notes that setting 'ret = -3' prior to the unconditional
setting of 'ret = 0' will cause the value to be UNUSED.

Since the comment indicates that it is expect to allow the code
to continue, just remove the ret = -3 setting.

Signed-off-by: John Ferlan <jferlan@redhat.com>
src/storage/storage_backend_fs.c

index b8f907aee11fa8bfa0b79723d438b4cc2951cb59..0f8ceee5498c61f7f472023f41131eec5886df12 100644 (file)
@@ -128,7 +128,6 @@ virStorageBackendProbeTarget(virStorageSourcePtr target,
                 virReportError(VIR_ERR_INTERNAL_ERROR,
                                _("cannot probe backing volume format: %s"),
                                target->backingStore->path);
-                ret = -3;
             } else {
                 target->backingStore->format = rc;
             }